[Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

Nanley Chery nanleychery at gmail.com
Thu Oct 22 15:22:08 PDT 2015

On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov <emil.l.velikov at gmail.com>

> On 20 October 2015 at 16:43, Nanley Chery <nanleychery at gmail.com> wrote:
> > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák <maraeo at gmail.com> wrote:
> >>
> >> Also, the FIXME comment should be on its own line.
> >>
> >
> > I moved it aside to make editing the table easier. However, since the
> > formatting of the
> > table is unlikely to change much after this series, I agree that I should
> > move it back to
> > its original position.
> >
> Actually the designated initalisers should be fine in core mesa. If in
> doubt wrt MSVC compat, just grep MSVC.*COMPAT through whole of mesa.
> The 2013 version adds support for this feature.
> Alternatively feel free to ask Brian/Jose, as they have a fair bit of
> experience in the area.
That's good news. Thanks for the information.

> That aside, I'm in favour of keeping the comments as is. The editing
> comment does not apply imho.
Since, there isn't a unanimous opinion on this, I'll leave the FIXME
to save some rebasing time. Are you referring to my git comment?
Or to my previous reply about why I moved the FIXME?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151022/e31092f1/attachment.html>

More information about the mesa-dev mailing list