[Mesa-dev] [RFC 15/21] mesa: Fix EXT_texture_sRGB functionality leaks

[Nanley Chery]

On Thu, Oct 22, 2015 at 12:15 PM, Chad Versace <chad.versace at intel.com>
wrote:

> On Mon 19 Oct 2015, Nanley Chery wrote:
> > From: Nanley Chery <nanley.g.chery at intel.com>
> >
> > Stop leaks into the following contexts:
> >    * GLES in _mesa_base_tex_format() and lookup_view_class().
> >    * Pre-1.1 GL legacy contexts in all uses.
> >
> > Stop allowing compressed sRGB formats as valid formats in GLES3
> > contexts. I realized this was happening when CTS failures occured after
> > fixing the extension functionality leak with the helper function.
>
> Do you mean that this patch *fixes* CTS failures? If so, which CTS for
> which GLES version?  There are so many CTS's in the world :(
>

I meant that when I first modified _mesa_base_tex_format() to use the helper
function, I had failures in piglit, dEQP, and the Khronos CTS. "failures in
every
test-suite" probably would've been better than "CTS failures" here. It was
because of those failures, that I realized that we were incorrectly allowing
formats like GL_COMPRESSED_SRGB_EXT in GLES contexts. This motivated
the split of the switch statement you see in the diff of
_mesa_base_tex_format().
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151023/63387547/attachment.html>