[Mesa-dev] [PATCH 2/2] i965: Set Y-tiling for qualified rotated scanout buffers

[Ben Widawsky]

On Fri, Oct 23, 2015 at 06:19:02PM -0700, Vivek Kasireddy wrote:
> On Thu, 22 Oct 2015 21:12:02 -0700
> Ben Widawsky <ben at bwidawsk.net> wrote:
> 
> > On Thu, Oct 22, 2015 at 06:44:53PM -0700, Vivek Kasireddy wrote:
> > > On newer hardware platforms that support rotation, if the gbm
> > > interface requests to create a rotated scanout buffer via the
> > > flag __DRI_IMAGE_USE_SCANOUT_ROTATED_90_270, set Y-tiling
> > > while creating the buffer.
> > > 
> > > Cc: Kristian Hogsberg <krh at bitplanet.net>
> > > Signed-off-by: Vivek Kasireddy <vivek.kasireddy at intel.com>
> > 
> > FYI, I'd been hoping to land a superset of this for quite a while. My
> > understanding was the DDX doesn't support it.
> > 
> > http://patchwork.freedesktop.org/patch/46984/
> 
> Hi Ben,
> I am sorry I wasn't aware of your patch. I am testing this feature with
> a Wayland/Weston based compositor. 
> 
> Thanks and Regards,
> Vivek
> 

That's fine. It's a really old patch by now. It would be really great if we
could have something which works in X too.

> > 
> > > ---
> > >  src/mesa/drivers/dri/i965/intel_screen.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
> > > b/src/mesa/drivers/dri/i965/intel_screen.c index 590c45d..1079676
> > > 100644 --- a/src/mesa/drivers/dri/i965/intel_screen.c
> > > +++ b/src/mesa/drivers/dri/i965/intel_screen.c
> > > @@ -525,6 +525,12 @@ intel_create_image(__DRIscreen *screen,
> > >  
> > >     if (use & __DRI_IMAGE_USE_LINEAR)
> > >        tiling = I915_TILING_NONE;
> > > +   else if (use & __DRI_IMAGE_USE_SCANOUT_ROTATED_90_270) {
> > > +      if (intelScreen->devinfo->gen >= 9)
> > > +         tiling = I915_TILING_Y;
> > > +      else
> > > +         return NULL;
> > > +   }
> > >  
> > >     image = intel_allocate_image(format, loaderPrivate);
> > >     if (image == NULL)
> > > -- 
> > > 2.4.3
> > > 
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>