[Mesa-dev] [PATCH v6 2/2] mesa/teximage: accept ASTC formats for 3D texture specification

[Nanley Chery]

On Mon, Oct 26, 2015 at 11:15 AM, Neil Roberts <neil at linux.intel.com> wrote:

> Nanley Chery <nanleychery at gmail.com> writes:
>
> > +      /* Throw an INVALID_OPERATION error if the target is
> > +       * TEXTURE_CUBE_MAP_ARRAY and the format is not ASTC.
> > +       */
> > +      if (target_can_be_compresed &&
> > +          ctx->Extensions.KHR_texture_compression_astc_ldr &&
> > +          layout != MESA_FORMAT_LAYOUT_ASTC)
> >           return write_error(error, GL_INVALID_OPERATION);
>
> This seems to cause regressions in the following Piglit tests for Gen9:
>
> piglit.spec.ext_texture_compression_s3tc.getteximage-targets cube_array
> s3tc
> piglit.spec.arb_texture_cube_map_array.fbo-generatemipmap-cubemap array
> s3tc_dxt1
>
> I think the spec for the extension is based on the GLES spec. Perhaps
> the intention was to add ASTC support for cube-map array textures
> whereas previously in GLES no compressed formats were supported for this
> target. However in regular GL presumably S3TC is supposed to be
> supported. As it stands this patch disables cube-map array textures for
> any formats other than ASTC whenever the ASTC extension is available, so
> it disables S3TC on Gen9.
>
> Maybe this section should be limited to GLES?
>
>
Limiting this to GLES sounds like a good solution. Note that there is
similar logic for the
TEXTURE_3D target further down.

Nanley


> Regards,
> - Neil
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151026/ce14201c/attachment.html>