[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92552

--- Comment #9 from Ian Romanick <idr at freedesktop.org> ---
Comment on attachment 119006
  --> https://bugs.freedesktop.org/attachment.cgi?id=119006
egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS

Review of attachment 119006:
-----------------------------------------------------------------

There are a few things wrong with this patch.  First, you can't check the
version when you see EGL_CONTEXT_FLAGS in the attribs list because the
application could specify the requested version after flags.  This should not
generate an error:

    EGL_CONTEXT_FLAGS, EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR,
    EGL_CONTEXT_CLIENT_VERSION, 3,
    0

Second, it is not correct to generate EGL_BAD_MATCH for
EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR when EGL_EXT_create_context_robustness
is not supported.  Think of it this way... if we deleted all support and
knowledge of EGL_EXT_create_context_robustness, what error would be generated? 
Default case in the switch statement says EGL_BAD_ATTRIBUTE.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151026/17ed0424/attachment.html>