[Mesa-dev] [PATCH] i965: Set correct field for indirect align16 addrimm.

[Ian Romanick]

On 10/26/2015 11:10 AM, Matt Turner wrote:
> This has been wrong since the initial import of the i965 driver.

That is awesome.  Other than using the assembly validator, is there any
way to trigger this?  I assume you discovered this bug by inspection...

> ---
>  src/mesa/drivers/dri/i965/brw_eu_emit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
> index ebd811f..df48590 100644
> --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
> +++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
> @@ -410,7 +410,7 @@ brw_set_src0(struct brw_codegen *p, brw_inst *inst, struct brw_reg reg)
>           if (brw_inst_access_mode(devinfo, inst) == BRW_ALIGN_1) {
>              brw_inst_set_src0_ia1_addr_imm(devinfo, inst, reg.dw1.bits.indirect_offset);
>  	 } else {
> -            brw_inst_set_src0_ia_subreg_nr(devinfo, inst, reg.dw1.bits.indirect_offset);
> +            brw_inst_set_src0_ia16_addr_imm(devinfo, inst, reg.dw1.bits.indirect_offset);
>  	 }
>        }
>  
>