[Mesa-dev] [PATCH] i965: Do legacy userclipping in OpenGL ES 1.x contexts.

[Kenneth Graunke]

On Tuesday, October 27, 2015 02:56:24 PM Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Commit fba4823a disabled user clipping for everything except
> compatibility profile.  Core profile and OpenGL ES 2.0+ have all removed
> the classic, OpenGL 1.0 user clip planes.  ES 1.x, however, still has
> them.
> 
> Fixes OpenGL ES 1.1 conformance mustpass.c and userclip.c
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92639
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92641
> ---
>  src/mesa/drivers/dri/i965/brw_vs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_vs.c b/src/mesa/drivers/dri/i965/brw_vs.c
> index 5db4b3a..0b805b1 100644
> --- a/src/mesa/drivers/dri/i965/brw_vs.c
> +++ b/src/mesa/drivers/dri/i965/brw_vs.c
> @@ -311,7 +311,8 @@ brw_vs_populate_key(struct brw_context *brw,
>     key->program_string_id = vp->id;
>  
>     if (ctx->Transform.ClipPlanesEnabled != 0 &&
> -       ctx->API == API_OPENGL_COMPAT &&
> +       (ctx->API == API_OPENGL_COMPAT ||
> +        ctx->API == API_OPENGLES) &&
>         vp->program.Base.ClipDistanceArraySize == 0) {
>        key->nr_userclip_plane_consts =
>           _mesa_logbase2(ctx->Transform.ClipPlanesEnabled) + 1;
> 

Thanks for fixing this, Ian...I looked at ES2 and ES3 but totally forgot
about ES1...

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151027/92472272/attachment.sig>