[Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

Ilia Mirkin imirkin at alum.mit.edu
Wed Oct 28 21:26:36 PDT 2015

On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick <idr at freedesktop.org> wrote:
> People often complain about the way that open-source projects are so nit
> picky about coding standards.  It's a necessary survival tactic.  Mesa
> is 22 years old.  It has had dozens of contributors.  Imagine how much

There are like 10 different areas in mesa and they all have their own
styles. Each area is often strict on its style, but that style is
strictly different from other areas. 3-space indent, 4-space tabs,
8-space tabs, indent next line to some (imho) weird rule, case
indented from switch, case not indented. Not to mention the places
that are one line with tabs, one without, one with some tabs and some
spaces, etc.

In past lives, I've often been on the side of "oh noes, fixing it all
will mess up history", but experience with a few times where I've lost
that battle(/not cared enough) has taught me that it's not such a big
deal. Even if you go and change *every single line* in the project,
it's not that big of a deal. git blame -w ignores whitespace changes,
and even for more substantial churn all you end up having to do is run
one extra command in some situations. I find that I write/modify code
a lot more often than I do git blames. And I spend even more time
thinking about the code I write, so typing "struct" or anything like
that is never an issue.

I would definitely be in favor of doing a major cleanup if some
baseline rules can be agreed upon.


More information about the mesa-dev mailing list