[Mesa-dev] [PATCH v2] mesa/teximage: Fix S3TC regression due to ASTC interaction

[Emil Velikov]

Hi Nanley,

On 28 October 2015 at 21:50, Nanley Chery <nanleychery at gmail.com> wrote:
> From: Nanley Chery <nanley.g.chery at intel.com>
>
> A prior, literal reading of the ASTC spec led to the prohibition
> of some compressed formats being used against the targets:
> TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Since the spec does not specify
> interactions with other extensions for specific compressed textures,
> remove such interactions.
>
> Fixes the following Piglit tests on Gen9:
> piglit.spec.arb_direct_state_access.getcompressedtextureimage
> piglit.spec.arb_get_texture_sub_image.arb_get_texture_sub_image-getcompressed
> piglit.spec.arb_texture_cube_map_array.fbo-generatemipmap-cubemap array s3tc_dxt1
> piglit.spec.ext_texture_compression_s3tc.getteximage-targets cube_array s3tc
>
> v2. Don't interact with other specific compressed formats (Ian).
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91927
Small suggestion:

For future patches, please mention the commit sha/title as regressions
like these happen.
Not a strict requirement by any means, but quite useful for devs,
testers and users alike.

Thanks
Emil