[Mesa-dev] [PATCH v2] st/mesa: fix mipmap generation for immutable textures with incomplete pyramids

Emil Velikov emil.l.velikov at gmail.com
Thu Oct 29 16:51:35 PDT 2015

On 29 October 2015 at 22:56, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 29.10.2015 14:13, Marek Olšák wrote:
>> On Wed, Oct 28, 2015 at 1:00 PM, Nicolai Hähnle <nhaehnle at gmail.com>
>> wrote:
>>> Without the clamping by NumLevels, the state tracker would reallocate the
>>> texture storage (incorrect) and even fail to copy the base level image
>>> after reallocation, leading to the graphical glitch of
>>> https://bugs.freedesktop.org/show_bug.cgi?id=91993 .
>>> A piglit test has been submitted for review as well (subtest of
>>> arb_texture_storage-texture-storage).
>>> v2: also bypass all calls to st_finalize_texture (suggested by Marek
>>> Olšák)
>>> Cc: mesa-stable at lists.freedesktop.org
>>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>> This looks good.
>> (a minor nit: an updated patch should not contain any reviewed-by
>> tags, because the updated version hadn't been seen by anybody at the
>> time of sending it to the list; it's okay to keep the tag now that
>> I've reviewed it)
> Sorry about that, I'll be more careful about that in the future.
Fwiw some of us tend to add the revision based on which the r-b was
given, when the revision history is present in the commit message.
Something like:

v2: Changed foo and bar.

Reviewed-by: Slim Shady <slim at shady.com> (v1)

Then again, you might want to follow your colleague's suggestion.

More information about the mesa-dev mailing list