[Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

Emil Velikov emil.l.velikov at gmail.com
Fri Oct 30 10:41:45 PDT 2015

On 29 October 2015 at 21:50, Dave Airlie <airlied at gmail.com> wrote:
> On 29 October 2015 at 21:12, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 29 October 2015 at 11:12, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Hi all,
>>> A slightly longer series (that builds on top of the previous sent a
>>> minute ago), that moves/renames a couple of files, adds a few inline
>>> wrappers, 'includes what you want' and related fixes.
>>> As some of these can be seen as bikeshedding, although rest assured
>>> there is a method to the madness, I think.
> While I do consider some of it bikesheddy in nature, I can't argue
> against any of it,
> All these look good to me, and the other 6 as well.
Thanks Dave. I had my fair share of bikeshedding for this year, so
there shouldn't be many more of those from me.

Out of curiosity:
What's the purpose behind the set but unused mapped variable ? Afaict
only kms-dri is actually using it whereas sw/dri, sw/xlib and
virgl/vtest one can just nuke it. Perhaps it's meant as part of future
work, that never came to be ?


More information about the mesa-dev mailing list