[Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

[Ilia Mirkin]

On Tue, Sep 1, 2015 at 6:53 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Tue, Sep 1, 2015 at 3:57 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> ---
>> I checked the uses of count_attribute_slots() and it looks like they're
>> expecting this already, but these two patches definitely need testing on
>> a driver that supports fp64.
>
> Whoops, assuming things go well this should also be Cc'd to 10.6 and 11.0.

Sooo.... I can't tell whether your patch upsets this, but just want to
make sure you're aware of this behaviour: Even though the driver is
allowed to count doubles as double-wide on the back end for the
purposes of max attributes, double vertex attributes are still only
supposed to count as a single slot where bindings are concerned.

I'll run these through a piglit -t fp64 though, hopefully that picks
up any piglit tests that were supposed to catch this sort of thing.

  -ilia