[Mesa-dev] Adaptive Vsync

[Albert Freeman]

The reply from Eric Anholt made two suggestions that should not be
difficult to implement for someone who made the patch in the first
place. Why would code be committed when improvements could be easily
made? From what I have seen, this kind of thing happens even to
experienced mesa developers who know exactly what they are doing.

It is much better to arrive at a solution without the issue now than
wait a few years (or some other period of time) for it to be replaced
by someone who has likely forgotten the details involved with its
implementation (or by someone who did not write the code in the first
place).

On 5 September 2015 at 16:09, Lauri Kasanen <cand at gmx.com> wrote:
> On Sat, 5 Sep 2015 15:41:00 +0200
> Benjamin Bellec <b.bellec at gmail.com> wrote:
>
>> Hello Lauri,
>>
>> I saw that your patch implementing adaptive vsync is not committed to mesa.
>> Ref,
>> http://lists.freedesktop.org/archives/mesa-dev/2013-December/050184.html
>>
>> Why not ? Is there any issue with it ? As a end user, adaptive vsync seems
>> a nice feature. But maybe I'm not aware of drawbacks.
>
> Hi,
>
> There was one drawback, it was worse for one-frame hickups:
> http://lists.freedesktop.org/archives/mesa-dev/2014-February/053888.html
>
> That alone wouldn't prevent using it IMHO, as the
> heavier-scenes-that-last-for-minutes is a valid use case. I just got
> tired of trying to push it, when it took nearly three months to get a
> review.
>
> Nowadays I prefer to contribute to projects where patches don't go
> unnoticed for months at a time.
>
> - Lauri
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev