[Mesa-dev] [PATCH] i965/nir/vec4: removed unneeded tex src swizzle set

Jason Ekstrand jason at jlekstrand.net
Sat Sep 5 21:30:55 PDT 2015


On Sep 5, 2015 6:27 AM, "Alejandro PiƱeiro" <apinheiro at igalia.com> wrote:
>
> At that point the swizzle should be correct.
> ---
>
> First versions of commit 19cf9 included some manual
> swizzle assignment that got removed after review [1],
> as get_nir_src with the right number of components
> should set a proper swizzle on most of the cases. This
> one was overlooked.

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

> [1] http://lists.freedesktop.org/archives/mesa-dev/2015-July/089810.html
>
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index 0ff298e..f6e59ce 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -2624,7 +2624,6 @@ vec4_visitor::emit_texture(ir_texture_opcode op,
>             mrf = param_base;
>             writemask = WRITEMASK_W;
>          }
> -         lod.swizzle = BRW_SWIZZLE_XXXX;
>          emit(MOV(dst_reg(MRF, mrf, lod.type, writemask), lod));
>        } else if (op == ir_txf) {
>           emit(MOV(dst_reg(MRF, param_base, lod.type, WRITEMASK_W), lod));
> --
> 2.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150905/0874bc58/attachment.html>


More information about the mesa-dev mailing list