[Mesa-dev] [PATCH 00/15] Resolve further GCC sign-compare warnings

[Jan Vesely]

On Tue, 2015-09-08 at 20:12 +1000, Rhys Kidd wrote:
> Continued progress towards addressing all GCC sign-compare warnings
> across
> Mesa (at least as compiled for i965 hw).
> 
> As a new contributor, I am continuing to focus on manageable, easily
> reviewed,
> discrete improvements. This patchset resolves a number of warnings
> reported
> by GCC when configured to be pedantic.
> 
> Unlikely to be any performance improvements, however code quality is
> enhanced.
> 
> $ gcc --version
> gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
> 
> No piglit regressions on Ironlake. 
> 
> Rhys Kidd (15):
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   mesa: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965/gen7: Resolve GCC sign-compare warning.
>   i965/gen8: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
> 
>  src/glsl/nir/nir_lower_tex_projector.c        | 6 +++---
>  src/glsl/nir/nir_opt_peephole_ffma.c          | 2 +-
>  src/glsl/nir/nir_search.c                     | 6 +++---
>  src/mesa/drivers/dri/i965/brw_eu_compact.c    | 4 ++--
>  src/mesa/drivers/dri/i965/brw_state_dump.c    | 4 ++--
>  src/mesa/drivers/dri/i965/brw_state_upload.c  | 2 +-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 ++++----
>  src/mesa/program/prog_to_nir.c                | 2 +-
>  8 files changed, 17 insertions(+), 17 deletions(-)
> 

I have some of these fixed locally. I think the series should be
squashed to 2 or 3 patches. patches 1-7,15 squashed into two are:
Reviewed-by: Jan Vesely <jan.vesely at rutgers.edu>

(I can't commit atm, you'll need to ask someone else)

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150908/7fc796c6/attachment.sig>