[Mesa-dev] [PATCH 00/15] Resolve further GCC sign-compare warnings

Thomas Helland thomashelland90 at gmail.com
Tue Sep 8 06:24:16 PDT 2015


Hi,

If you repost with the changes suggested by the others,
and add the Reviewed-by tag when reposting, I'll pull these
down (and the other series too), and get them merged
along with one other patch I have sitting.

You can add my reviewed-by to both series.

Thanks for the effort =)

2015-09-08 12:12 GMT+02:00 Rhys Kidd <rhyskidd at gmail.com>:
> Continued progress towards addressing all GCC sign-compare warnings across
> Mesa (at least as compiled for i965 hw).
>
> As a new contributor, I am continuing to focus on manageable, easily reviewed,
> discrete improvements. This patchset resolves a number of warnings reported
> by GCC when configured to be pedantic.
>
> Unlikely to be any performance improvements, however code quality is enhanced.
>
> $ gcc --version
> gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
>
> No piglit regressions on Ironlake.
>
> Rhys Kidd (15):
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>   mesa: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   i965/gen7: Resolve GCC sign-compare warning.
>   i965/gen8: Resolve GCC sign-compare warning.
>   i965: Resolve GCC sign-compare warning.
>   glsl: Resolve GCC sign-compare warning.
>
>  src/glsl/nir/nir_lower_tex_projector.c        | 6 +++---
>  src/glsl/nir/nir_opt_peephole_ffma.c          | 2 +-
>  src/glsl/nir/nir_search.c                     | 6 +++---
>  src/mesa/drivers/dri/i965/brw_eu_compact.c    | 4 ++--
>  src/mesa/drivers/dri/i965/brw_state_dump.c    | 4 ++--
>  src/mesa/drivers/dri/i965/brw_state_upload.c  | 2 +-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 ++++----
>  src/mesa/program/prog_to_nir.c                | 2 +-
>  8 files changed, 17 insertions(+), 17 deletions(-)
>
> --
> 2.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list