[Mesa-dev] [PATCH v2 0/3] Resolve further GCC sign-compare warnings

Rhys Kidd rhyskidd at gmail.com
Tue Sep 8 08:52:47 PDT 2015


Continued progress towards addressing all GCC sign-compare warnings across
Mesa (at least as compiled for i965 hw).

As a new contributor, I am continuing to focus on manageable, easily reviewed,
discrete improvements. This patchset resolves a number of warnings reported
by GCC when configured to be pedantic.

Unlikely to be any performance improvements, however code quality is enhanced.

$ gcc --version
gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2

No piglit regressions on Ironlake.

v2:
- Squash series into three related patches.

Rhys Kidd (3):
  glsl: Resolve GCC sign-compare warning.
  mesa: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.

 src/glsl/nir/nir_lower_tex_projector.c        | 6 +++---
 src/glsl/nir/nir_opt_peephole_ffma.c          | 2 +-
 src/glsl/nir/nir_search.c                     | 6 +++---
 src/mesa/drivers/dri/i965/brw_eu_compact.c    | 4 ++--
 src/mesa/drivers/dri/i965/brw_state_dump.c    | 4 ++--
 src/mesa/drivers/dri/i965/brw_state_upload.c  | 2 +-
 src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 ++++----
 src/mesa/program/prog_to_nir.c                | 2 +-
 8 files changed, 17 insertions(+), 17 deletions(-)

-- 
2.1.4



More information about the mesa-dev mailing list