[Mesa-dev] [PATCH 05/11] nir/from_ssa: Use instr_rewrite_dest

Eduardo Lima Mitev elima at igalia.com
Thu Sep 10 08:30:28 PDT 2015


On 09/10/2015 02:50 AM, Jason Ekstrand wrote:
> ---
>  src/glsl/nir/nir_from_ssa.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/glsl/nir/nir_from_ssa.c b/src/glsl/nir/nir_from_ssa.c
> index 084f43d..eaf883d 100644
> --- a/src/glsl/nir/nir_from_ssa.c
> +++ b/src/glsl/nir/nir_from_ssa.c
> @@ -512,9 +512,7 @@ rewrite_ssa_def(nir_ssa_def *def, void *void_state)
>      */
>     nir_dest *dest = exec_node_data(nir_dest, def, ssa);
>  
> -   *dest = nir_dest_for_reg(reg);
> -   dest->reg.parent_instr = state->instr;
> -   list_addtail(&dest->reg.def_link, &reg->defs);
> +   nir_instr_rewrite_dest(state->instr, dest, nir_dest_for_reg(reg));
>  
>     return true;
>  }
> 

This patch and 04/11 (considering comment by Michael Schellenberger) are
both

Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>



More information about the mesa-dev mailing list