[Mesa-dev] [PATCH V2 5/8] i965: Move conversion of {src, dst}_pitch to dwords outside if/else

[Chad Versace]

On Wed 19 Aug 2015, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/intel_blit.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c
> index c177eec..d15a64d 100644
> --- a/src/mesa/drivers/dri/i965/intel_blit.c
> +++ b/src/mesa/drivers/dri/i965/intel_blit.c

[snip]

> @@ -645,17 +636,19 @@ intelEmitCopyBlit(struct brw_context *brw,
>        CMD = xy_blit_cmd(src_tiling, src_tr_mode,
>                          dst_tiling, dst_tr_mode,
>                          cpp, use_fast_copy_blit);
> +   }
>  
> -      if (dst_tiling != I915_TILING_NONE)
> -         dst_pitch /= 4;
> +   /* For tiled source and destination, pitch value should be specified
> +    * as a number of Dwords.
> +    */
> +   if (dst_tiling != I915_TILING_NONE)
> +      dst_pitch /= 4;
>  
> -      if (src_tiling != I915_TILING_NONE)
> -         src_pitch /= 4;
> -   }
> +   if (src_tiling != I915_TILING_NONE)
> +      src_pitch /= 4;
>  
> -   if (dst_y2 <= dst_y || dst_x2 <= dst_x) {
> +   if (dst_y2 <= dst_y || dst_x2 <= dst_x)
>        return true;
> -   }

The diff's last 4 lines add noise to the diff, and I'd like to see that
as a seprate mini-patch.

Either way, with or without the separate mini-patch, patch 5/8 is
Reviewed-by: Chad Versace <chad.versace at intel.com>