[Mesa-dev] [PATCH 3/9] nir: Report progress from lower_vec_to_movs().

[Kenneth Graunke]

On Friday, September 18, 2015 10:55:34 AM Jason Ekstrand wrote:
> Um, why?  I'm sure you have some reason but I don't immediately see how a
> progress flag from lower_vec_to_movs is useful.  Some of the others
> definitely are.
> --Jason

Sorry, I should have explained in at least one of the patches.

I'm hoping to create an OPT() macro, similar to what we do for i965
passes.  It would:

1. Run the pass.
2. Call nir_validate_shader() if we actually made any progress.
3. Optionally nir_print_shader() if we made any changes.
   (i.e. let us do INTEL_DEBUG=optimizer but for NIR passes)

I need to know whether a pass made progress in order to decide whether
or not to dump the shader.  I might want to see the code before and
after nir_lower_vec_to_movs().

Also, having some passes return 'bool' and some return 'void' is
awkward: I can't wrap void-return functions in the same sort of macro.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150918/029a8d1a/attachment.sig>