[Mesa-dev] [PATCH 0/8] RadeonSI: New tool for VM fault debugging

[Michel Dänzer]

On 28.09.2015 07:53, Marek Olšák wrote:
> Hi,
> 
> This adds 2 things:
> 
> 1) R600_DEBUG=check_vm - which checks dmesg for VM faults for each submitted IB and if a VM fault appears, it writes a debug report to a file with the failing address.
> 
> 2) Writes a buffer list for that IB into the report file along with a description how each buffer was used.
> 
> This is the resulting file converted into html. The buffers are sorted according to their VM address. It's not a real VM fault, just an artifically triggered report using an old VM fault that had already been in dmesg:
> - http://people.freedesktop.org/~mareko/check_vm.html
> 
> Please review.

Nice work. Apart from the minor comments I made on individual patches,
the series is

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


> Future work / desirable features:
[...]
> - add holes between buffers in the VM for a better chance of getting VM faults

I have an idea for this: We could add the VM address space alignment to
the BO size for allocating / freeing VM address space in userspace. That
would leave holes without the need for tracking them explicitly in the
list of unallocated ranges. For the amdgpu winsys, this would have to be
done in libdrm_amdpgu.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer