[Mesa-dev] [PATCH 8/8] radeonsi: dump buffer lists while debugging

Marek Olšák maraeo at gmail.com
Mon Sep 28 01:02:17 PDT 2015


On Mon, Sep 28, 2015 at 3:38 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 28.09.2015 07:53, Marek Olšák wrote:
>> +             /* Note: Buffer sizes are expected to be aligned to 4k by the winsys. */
>> +             const unsigned page_size = 4096;
>
> This stems from TTM; it requires BOs to be aligned to the CPU page size,
> which can be larger than 4096 bytes. We should try to reduce the places
> where we hardcode 4096 bytes, not add to them. :)

I understand, but in this case it's just a convenient choice of units
for the report, not a CPU page size. If the CPU used bigger pages, I'd
still like 4096 to be hardcoded here for consistency with report files
from other CPUs.

Marek


More information about the mesa-dev mailing list