[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

[Kyle Brenneman]

On 09/28/2015 11:33 AM, Emil Velikov wrote:
> Hi Kyle,
>
> On 25 September 2015 at 21:01, Kyle Brenneman <kbrenneman at nvidia.com> wrote:
>> Add a macro GL_LIB_NAME to hold the filename that configure comes up with
>> based on the --with-gl-lib-name and --enable-mangling options.
>>
>> In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding
>> "libGL.so.1".
>>
>> v2: Add an #ifndef/#define for GL_LIB_NAME so that non-autoconf builds will
>>      work.
>> v3: Fix the library filename in the Makefile.
> Did you really come across issues due to this or have you just noticed
> it while going through ? I've been dreaming about getting rid of this
> hack/workaround, although until that happens (if ever) this commit is
> doing the right thing.
I did come across issues from this, although it was from kind of an 
oddball corner case. I was experimenting with writing a wrapper library 
to make an (otherwise unmodified) build of Mesa work with libglvnd, 
using the --enable-mangling and --with-gl-lib-name options, and got 
undefined symbol errors as a result.
>
> Please add your s-o-b and the mesa-stable tag. With those
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> Thanks
> Emil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150928/775556b1/attachment.html>