[Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

Emil Velikov emil.l.velikov at gmail.com
Fri Apr 1 13:05:53 UTC 2016


On 21 February 2016 at 19:57, Mauro Rossi <issor.oruam at gmail.com> wrote:
> Hi Micheal,
>
> no problem, I'm learning so much and you and Emil have both shown amounts of
> patience with me.
>
> I've tested the following patch and it works
>
Mauro, please send patches that can be applied without rewriting them.
As the Gmail web interface alters the contents of the email, I'd
suggest using git send-email. Iirc you used it a while back ?

If you have some comments that shouldn't appear in the patch (like in
this case), just add them after the --- like illustrated below.

I believe you don't have any other outstanding patches send to the
mailing list, correct ? Can you please send out all the delta vs
android-x86. Some of the patches might need a bit of rework, but
pretty much all of them look reasonable.

Thanks
Emil

>From a00b1182fd74ec6af37e09e53dd3febec36af27d Mon Sep 17 00:00:00 2001
From: Mauro Rossi <issor.oruam at gmail.com>
Date: Sun, 21 Feb 2016 20:31:21 +0100
Subject: [PATCH] radeonsi: use util_strchrnul() to fix android building
error

Android Bionic does not support strchrnul() string function,
gallium auxiliary util/u_string.h provides util_strchrnul()

This change avoids the following building error:

external/mesa/src/gallium/drivers/radeonsi/si_shader.c:3863: error:
undefined reference to 'strchrnul'
collect2: error: ld returned 1 exit status
---

Newly added comment that won't appear in git history, aimed for reviewers.

 src/gallium/drivers/radeonsi/si_shader.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


More information about the mesa-dev mailing list