[Mesa-dev] [PATCH 0/9] Remove duplicated src/compiler/*/Makefile.sources

[Emil Velikov]

On 5 April 2016 at 18:47, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Tue, Apr 5, 2016 at 9:49 AM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
>>
>> Hi all,
>>
>> I believe the title says it all. Additionally there are a couple of nice
>> fixes (patches 1, 4 and 9) and a few possibly controversial changes in -
>> patches 6, 7 and 8. The later split the contents of the Makefiles
>> preserving the parallelism.
>
>
> Thanks for working on this!  I actually really like the changes in 6, 7, and
> 8.  I've always hated having to dig through that giant makefile.
>
Glad to hear I'm not the only one there :-)

> I don't think I can give it a *real* review since there's a lot of stuff in
> there that I don't know but it looks good as far as I can tell.
>
> Acked-by: Jason Ekstrand <jason at jlekstrand.net>
>
> Did you try and build with MSVC and Android?  I have no idea what your build
> setup looks like.
Using Travis-CI for the windows builds - scons is ok
Linux - both scons and make are fine
Android - not tested I'm afraid. Rob H can you give it a spin - I
don't expect issues, yet one never knows. Branch deduplicate-makefiles
at https://github.com/evelikov/Mesa/

Thanks
Emil
P.S. Master is a bit broken with swr being the more serious offender