[Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

Jose Fonseca jfonseca at vmware.com
Fri Apr 8 08:37:28 UTC 2016


On 02/04/16 19:35, Rob Clark wrote:
> From: Rob Clark <robclark at freedesktop.org>
>
> Allegedly this was needed still by scons build.. but in practice it
> doesn't seem to be needed.  Removing it and running 'scons' results
> in no build errors.
>
> Signed-off-by: Rob Clark <robclark at freedesktop.org>
> ---
> So, afaict NIR is not even built w/ scons build (I'm just running
> 'scons' with no args, so let me know if I'm missing some build
> variant).  So at least if there is no scons variant that *does*
> build NIR, I think this is the right thing to do to reduce
> confusion.  But it brings up a bigger question of what to do
> with my patchset which adds NIR support in mesa/st, since that
> obviosly won't work with scons build as-is.
>
> I guess the two options are to try to add NIR into scons build
> (which involves some .py generated code, so maybe not trivial)
> or just #ifdef'ify all the mesa/st parts in my gallium-nir
> patchset which introduce dependencies on NIR.  Opinions?

If you might recall, I already had patches to build NIR with SCons:

   http://cgit.freedesktop.org/~jrfonseca/mesa/log/?h=scons-nir

I ended up not taking any action at the time.  First due to lack of 
time, second because I noticed NIR source trees being moving around, so 
the risk of exposing scons build to breakage didn't seem worthwhile.

So those changes need to be rebased and probably updated a bit, but it 
gives you an idea of what needs to be done.

Jose



More information about the mesa-dev mailing list