[Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

[Marek Olšák]

On Tue, Apr 12, 2016 at 7:59 PM, Ernst Sjöstrand <ernstp at gmail.com> wrote:
> 2016-04-12 19:27 GMT+02:00 Ian Romanick <idr at freedesktop.org>:
>> On 04/12/2016 09:39 AM, Marek Olšák wrote:
>>> On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>>> On 04/12/2016 05:21 AM, Marek Olšák wrote:
>>>>> On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>>>>> radeon and r200 have a driconf option that is similar to this.  It sets
>>>>>> a default initial max anisotropy value.  Maybe that would be better?
>>>>>
>>>>> If driconf didn't copy /etc/drirc into ~/.drirc, it would indeed be
>>>>> better. This needs to be fixed in driconf before we can consider it
>>>>> usable. After that, we can move such options there.
>>>>
>>>> I'm not sure what that means.  You mean the driconf app?
>>>
>>> Yes, the driconf app. It unconditionally copies all app workarounds
>>> into ~/.drirc and following Mesa updates can't remove them. If you
>>> don't run driconf, ~/.drirc won't be created and you'll always get
>>> updated app workarounds with newer Mesa.
>>
>> That sounds awful... as a user, I'm pretty sure that would fill me with
>> rage.  It seems like the app should only operate on the user's ~/.drirc.
>>  Having an "import from /etc/drirc" button seems like the right answer.
>>  Forcing it on people is never right. :(
>
> Isn't the best strategy to overlay (merge) /etc/drirc with the users changes?

No if /etc/drirc contains app-specific workarounds which may change or
be removed with newer Mesa. Copying those into ~/.drirc has caused
problems with Heaven:
- Phoronix was unable to test tessellation and saw lower performance
in Heaven because of stale ~/.drirc
- Other users have had the same issue.

Both files should already be merged by Mesa during driver loading.
There is no need for driconf to copy settings from one file to
another.

driconf seems to be hosted here:
https://sourceforge.net/projects/driconf/

Marek