[Mesa-dev] [PATCH 1/2] meta: Don't smash ColorMask when using MESA_META_COLOR_MASK save bit.

[Jason Ekstrand]

On Tue, Apr 12, 2016 at 4:24 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> On Tuesday, April 12, 2016 4:07:30 PM PDT Jason Ekstrand wrote:
> > On Apr 12, 2016 1:41 PM, "Kenneth Graunke" <kenneth at whitecape.org>
> wrote:
> > >
> > > This allows meta operations to inspect the existing color mask, and
> > > then do their own smashing.
> >
> > I don't like this.  Part of the point of meta begin is to sanitize the
> > context.  Color masks seem like one of those things we should sanitize.
> >
> > That said, this isn't a NAK... I just don't like it.  I'm looking at your
> > other patch to see how needed this really is.
> >
> > --Jason
>
> I disagree - the point of meta begin is to save/restore state.
>
> Not all passes want it "sanitized" to the same state.  They want to
> alter it in some way.  It should be up to each pass to set the state
> that they want.
>
> Sometimes we set the state in _mesa_meta_begin(), but that's only when
> when all passes want the same setting.  This is no longer the case, so
> I moved the logic to be per-pass.
>

I guess that's reasonable.  I'm not that attached to having it sanitized.
I am a bit nervous about how few files this touches but I guess a bunch of
the meta code just calls BlitFramebuffers.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160412/a01fd399/attachment.html>