[Mesa-dev] [PATCH v2] anv_device: Set the compressed texture feature flags correctly

[Jason Ekstrand]

On Fri, Apr 22, 2016 at 4:38 PM, Nanley Chery <nanleychery at gmail.com> wrote:

> From: Nanley Chery <nanley.g.chery at intel.com>
>
> Sampling from an ETC2 texture is supported on Bay Trail and
> from Gen8 onwards. While ASTC_LDR is supported on Gen9, the
> logic to handle such formats has not yet been implemented in
> the driver.
>
> Fixes dEQP-VK.api.info.format_properties.compressed_formats.
>
> v2: Enable ETC2 for Bay Trail (Kenneth Graunke)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94896
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/vulkan/anv_device.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 00edd95..4abcdf9 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -380,8 +380,9 @@ void anv_GetPhysicalDeviceFeatures(
>        .alphaToOne                               = true,
>        .multiViewport                            = true,
>        .samplerAnisotropy                        = false, /* FINISHME */
> -      .textureCompressionETC2                   = true,
> -      .textureCompressionASTC_LDR               = true,
> +      .textureCompressionETC2                   = pdevice->info->gen >= 8
> ||
> +
> pdevice->info->is_baytrail,
> +      .textureCompressionASTC_LDR               = false, /* FINISHME */
>

So... I thought that when I turned this on it passed all the ASTC CTS
tests.  We should double-check that before turning it off.
--Jason


>        .textureCompressionBC                     = true,
>        .occlusionQueryPrecise                    = true,
>        .pipelineStatisticsQuery                  = false,
> --
> 2.8.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160422/511f55c4/attachment.html>