[Mesa-dev] [PATCH 2/4] mesa: Disallow CopyTexSubImage on stencil formats in ES.

[Mark Janes]

Kenneth Graunke <kenneth at whitecape.org> writes:

> Fixes
> - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8
> - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample

After this patch was pushed, I still see Gen9 failures for
ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample

Test case 'ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample'..
INFO:GTFTestGL3Apply:texture_stencil8_multisample:State reset! (re-creating EGL context)
  Fail (Fail)

Any idea why it would fail in CI?  Perhaps the branch that the CI runs
has an older version of this test?

-Mark

>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/main/teximage.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 6ac6fb1..76b6584 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -2530,6 +2530,15 @@ copytexsubimage_error_check(struct gl_context *ctx, GLuint dimensions,
>        }
>     }
>  
> +   /* In the ES 3.2 specification's Table 8.13 (Valid CopyTexImage source
> +    * framebuffer/destination texture base internal format combinations),
> +    * all the entries for stencil are left blank (unsupported).
> +    */
> +   if (_mesa_is_gles(ctx) && _mesa_is_stencil_format(texImage->_BaseFormat)) {
> +      _mesa_error(ctx, GL_INVALID_OPERATION, "%s(stencil disallowed)", caller);
> +      return GL_TRUE;
> +   }
> +
>     /* if we get here, the parameters are OK */
>     return GL_FALSE;
>  }
> -- 
> 2.8.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev