[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

Andres Gomez agomez at igalia.com
Wed Aug 3 20:51:17 UTC 2016


Implicit conversions were added in the GLSL 1.20 spec version.

Signed-off-by: Andres Gomez <agomez at igalia.com>
---
 src/compiler/glsl_types.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp
index 8a06695..24aec25 100644
--- a/src/compiler/glsl_types.cpp
+++ b/src/compiler/glsl_types.cpp
@@ -1384,6 +1384,10 @@ glsl_type::can_implicitly_convert_to(const glsl_type *desired,
    if (this == desired)
       return true;
 
+   /* Prior to GLSL 1.20, there are no implicit conversions */
+   if (state && !state->is_version(120, 0))
+      return false;
+
    /* ESSL does not allow implicit conversions. If there is no state, we're
     * doing intra-stage function linking where these checks have already been
     * done.
-- 
2.8.1



More information about the mesa-dev mailing list