[Mesa-dev] [PATCH] anv: remove support for d32_sfloat_s8_uint

Jason Ekstrand jason at jlekstrand.net
Fri Aug 5 17:08:27 UTC 2016


On Aug 5, 2016 9:49 AM, "Lionel Landwerlin" <lionel.g.landwerlin at intel.com>
wrote:
>
> It doesn't seem like we have any support for 32bits of something + 8bits
of
> something else.

Not quite. Depth-stencil formats are weird because they describe two
different things at the same time. In our hardware (post Sandy Bridge) the
depth and stencil components are actually stored in different surfaces but
in the same VkImage.  We certainly can handle 32-bit depth with stencil, we
just need to get the blits working.

> This fixes
>
dEQP-VK.api.copy_and_blit.blit_image.all_formats.scaling_partial_d32_sfloat_s8_uint_d32_sfloat_s8_uint_nearest
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/intel/vulkan/anv_formats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_formats.c
b/src/intel/vulkan/anv_formats.c
> index 13bde90..7d92f80 100644
> --- a/src/intel/vulkan/anv_formats.c
> +++ b/src/intel/vulkan/anv_formats.c
> @@ -167,7 +167,7 @@ static const struct anv_format anv_formats[] = {
>     fmt(VK_FORMAT_S8_UINT,                 ISL_FORMAT_R8_UINT),
>     fmt(VK_FORMAT_D16_UNORM_S8_UINT,       ISL_FORMAT_UNSUPPORTED),
>     fmt(VK_FORMAT_D24_UNORM_S8_UINT,
 ISL_FORMAT_R24_UNORM_X8_TYPELESS),
> -   fmt(VK_FORMAT_D32_SFLOAT_S8_UINT,      ISL_FORMAT_R32_FLOAT),
> +   fmt(VK_FORMAT_D32_SFLOAT_S8_UINT,      ISL_FORMAT_UNSUPPORTED),
>
>     fmt(VK_FORMAT_BC1_RGB_UNORM_BLOCK,     ISL_FORMAT_DXT1_RGB),
>     fmt(VK_FORMAT_BC1_RGB_SRGB_BLOCK,      ISL_FORMAT_DXT1_RGB_SRGB),
> --
> 2.8.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160805/fa5d8172/attachment.html>


More information about the mesa-dev mailing list