[Mesa-dev] [PATCH v2 02/27] i965/miptree: Allow get_aux_isl_surf when there is no aux surface

[Jason Ekstrand]

On Sun, Jul 31, 2016 at 12:43 AM, Pohjolainen, Topi <
topi.pohjolainen at intel.com> wrote:

> On Sun, Jul 31, 2016 at 10:32:33AM +0300, Pohjolainen, Topi wrote:
> > On Tue, Jul 26, 2016 at 03:11:06PM -0700, Jason Ekstrand wrote:
> > > ---
> > >  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> > > index 8c63aa6..1911eef 100644
> > > --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> > > +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> > > @@ -3204,7 +3204,8 @@ intel_miptree_get_aux_isl_surf(struct
> brw_context *brw,
> > >     } else if (mt->fast_clear_state != INTEL_FAST_CLEAR_STATE_NO_MCS) {
> > >        *usage = ISL_AUX_USAGE_CCS_D;
> > >     } else {
> > > -      unreachable("Invalid MCS miptree");
> > > +      *usage = ISL_AUX_USAGE_NONE;
> >
> > I'm guessing you'd like to call intel_miptree_get_aux_isl_surf()
> > unconditionally in one of the following patches? After reading them
> quite a
> > bit this is still not obvious to me, and I think some rational is needed
> in
> > the commit message.
>
> It looks that this is not needed until patch 13?
>

patch 10 actually


> >
> > > +      return;
> > >     }
> > >
> > >     /* Figure out the format and tiling of the auxiliary surface */
> > > --
> > > 2.5.0.400.gff86faf
> > >
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160805/5ed3eb25/attachment.html>