[Mesa-dev] [PATCH 1/2] mesa: Document that _mesa_enum_to_string() returns non-null

Chad Versace chad at kiwitree.net
Thu Aug 11 18:27:50 UTC 2016


It always returns non-null, even if the number is an invalid enum.

Cc: Haixia Shi <hshi at chromium.org>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97
---
 src/mapi/glapi/gen/gl_enums.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py
index 62cc1b3..2eb9e16 100644
--- a/src/mapi/glapi/gen/gl_enums.py
+++ b/src/mapi/glapi/gen/gl_enums.py
@@ -83,7 +83,12 @@ static int compar_nr( const int *a, enum_elt *b )
 
 static char token_tmp[20];
 
-const char *_mesa_enum_to_string( int nr )
+/**
+ * This function always returns a string. If the number is a valid enum, it
+ * returns the enum name. Otherwise, it returns a numeric string.
+ */
+const char *
+_mesa_enum_to_string(int nr)
 {
    enum_elt *elt;
 
-- 
2.9.2



More information about the mesa-dev mailing list