[Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

[Andy Furniss]

Nayan Deshmukh wrote:
> Hi Andy,

> You are right :( It messes up chroma but only in case of sharpen at
> least for me.

Retested and denoise is also affected for me.

> I tried some changes and the chroma effects are fixed if we apply the sharpness
> filter to only to the first surface instead of all the surfaces of the buffer.
> Can you verify this?

If you mean changing surfaces[i] to surfaces[0] below, then it is
better, but there are still artifacts/chroma errors.

In addition to changing as above, changing sampler_views[0] seems
to fix denoise and negative sharpen, but gives a new sort of
artifact for positive sharpen.

>>>> +   for(i = 0; i < VL_MAX_SURFACES; ++i) {
>>>> +      if(sampler_views[i] != NULL && surfaces[i] != NULL) {
>>>> +         if (vmixer->noise_reduction.filter)
>>>> +            vl_median_filter_render(vmixer->noise_reduction.filter,
>>>> +                                    sampler_views[i], surfaces[i]);
>>>> +
>>>> +         if (vmixer->sharpness.filter)
>>>> +            vl_matrix_filter_render(vmixer->sharpness.filter,
>>>> +                                    sampler_views[i], surfaces[i]);