[Mesa-dev] [PATCH 1/5] i965/fs: Drop bogus writemasking disable bit from HALT instructions.

[Jason Ekstrand]

On Tue, Aug 16, 2016 at 1:54 PM, Francisco Jerez <currojerez at riseup.net>
wrote:

> This may have been the reason people ran into problems with
> non-uniform HALT instructions and ended up using the inefficient
> ANY16H/ANY8H predicates instead of ANY4H or NORMAL in order to prevent
> non-uniform discard.  The HALT instruction is able to handle
> non-uniform execution masks just fine.
>

Do you know why we were setting MASK_DISABLE?  Perhaps we were getting the
exec size wrong before?  In any case, if there's no piglig problems with
patch 2, then I'll believe it works.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


> ---
>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> index 647950f..22190f8 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> @@ -1053,11 +1053,7 @@ fs_generator::generate_discard_jump(fs_inst *inst)
>      * current block (or the program).
>      */
>     this->discard_halt_patches.push_tail(new(mem_ctx)
> ip_record(p->nr_insn));
> -
> -   brw_push_insn_state(p);
> -   brw_set_default_mask_control(p, BRW_MASK_DISABLE);
>     gen6_HALT(p);
> -   brw_pop_insn_state(p);
>  }
>
>  void
> --
> 2.9.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160816/dbfbe1c2/attachment.html>