[Mesa-dev] [PATCH 2/2] vbo: remove unnecessary max_basevertex computation

Marek Olšák maraeo at gmail.com
Thu Aug 18 09:53:30 UTC 2016


For the series:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Wed, Aug 17, 2016 at 11:12 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:

> The max basevertex is already computed and added into max_index by the
> caller, _tnl_draw_prims.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/mesa/vbo/vbo_split.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/src/mesa/vbo/vbo_split.c b/src/mesa/vbo/vbo_split.c
> index 2f95746..79d7dd4 100644
> --- a/src/mesa/vbo/vbo_split.c
> +++ b/src/mesa/vbo/vbo_split.c
> @@ -108,14 +108,6 @@ void vbo_split_prims( struct gl_context *ctx,
>                       vbo_draw_func draw,
>                       const struct split_limits *limits )
>  {
> -   GLint max_basevertex = prim->basevertex;
> -   GLuint i;
> -
> -   for (i = 1; i < nr_prims; i++)
> -      max_basevertex = MAX2(max_basevertex, prim[i].basevertex);
> -
> -   /* XXX max_basevertex is computed but not used, why? */
> -
>     if (ib) {
>        if (limits->max_indices == 0) {
>          /* Could traverse the indices, re-emitting vertices in turn.
> --
> 2.7.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160818/9f3dcac2/attachment.html>


More information about the mesa-dev mailing list