[Mesa-dev] [PATCH] mesa: validate the indirect param before the shader in DispatchComputeIndirect

Marek Olšák maraeo at gmail.com
Wed Aug 24 09:50:10 UTC 2016


On Tue, Aug 23, 2016 at 3:11 AM, Dave Airlie <airlied at gmail.com> wrote:
> [Mesa-dev] [PATCH 1/2] mesa/compute: move compute checks around for tests.
>
> where this came up before.

If the fix lands in gl45release before Monday 29/8, I promise I will
not push this patch. ;)

Marek


>
> Dave.
>
> On 23 August 2016 at 06:35, Marek Olšák <maraeo at gmail.com> wrote:
>> On Mon, Aug 22, 2016 at 5:22 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> Both direct and indirect compute match right now - both check the
>>> program, and then check the "other" parameters. If this change is
>>> made, I believe that _mesa_validate_DispatchCompute should be adjusted
>>> as well.
>>
>> Yeah, maybe. Is there any other incentive to do so? The patch is silly
>> as-is, but CTS is CTS. I've got no reason to make other silly changes
>> when CTS doesn't need them. :) We should probably fix CTS, but this is
>> easier.
>>
>> Marek
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list