[Mesa-dev] [PATCH 1/4] mapi/glapi: remove unused _glapi_check_table_not_null

Eric Engestrom eric.engestrom at imgtec.com
Fri Aug 26 10:40:50 UTC 2016


On Thu, Aug 25, 2016 at 04:58:58PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Function was never part of the API/ABI and the final user was removed
> with commit a73c6540d9a7f6e26d8568ba2fc522cb865f0a6c, back in 2010.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

This series is
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> ---
>  src/mapi/glapi/glapi_getproc.c | 20 --------------------
>  src/mapi/glapi/glapi_priv.h    |  4 ----
>  2 files changed, 24 deletions(-)
> 
> diff --git a/src/mapi/glapi/glapi_getproc.c b/src/mapi/glapi/glapi_getproc.c
> index a50b5b3..1348b15 100644
> --- a/src/mapi/glapi/glapi_getproc.c
> +++ b/src/mapi/glapi/glapi_getproc.c
> @@ -583,26 +583,6 @@ _glapi_get_dispatch_table_size(void)
>  
>  
>  /**
> - * Make sure there are no NULL pointers in the given dispatch table.
> - * Intended for debugging purposes.
> - */
> -void
> -_glapi_check_table_not_null(const struct _glapi_table *table)
> -{
> -#ifdef EXTRA_DEBUG /* set to DEBUG for extra DEBUG */
> -   const GLuint entries = _glapi_get_dispatch_table_size();
> -   const void **tab = (const void **) table;
> -   GLuint i;
> -   for (i = 1; i < entries; i++) {
> -      assert(tab[i]);
> -   }
> -#else
> -   (void) table;
> -#endif
> -}
> -
> -
> -/**
>   * Do some spot checks to be sure that the dispatch table
>   * slots are assigned correctly. For debugging only.
>   */
> diff --git a/src/mapi/glapi/glapi_priv.h b/src/mapi/glapi/glapi_priv.h
> index 337913a..4eb0911 100644
> --- a/src/mapi/glapi/glapi_priv.h
> +++ b/src/mapi/glapi/glapi_priv.h
> @@ -56,10 +56,6 @@ extern "C" {
>  /* getproc */
>  
>  extern void
> -_glapi_check_table_not_null(const struct _glapi_table *table);
> -
> -
> -extern void
>  _glapi_check_table(const struct _glapi_table *table);
>  
>  
> -- 
> 2.9.0


More information about the mesa-dev mailing list