[Mesa-dev] [PATCH 2/2] clover: Use device cap to query pointer size instead of hardcoded 32bits

Francisco Jerez currojerez at riseup.net
Sun Aug 28 20:34:28 UTC 2016


Jan Vesely <jan.vesely at rutgers.edu> writes:

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97513
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  src/gallium/state_trackers/clover/api/device.cpp  | 2 +-
>  src/gallium/state_trackers/clover/core/device.cpp | 6 ++++++
>  src/gallium/state_trackers/clover/core/device.hpp | 1 +
>  3 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp
> index 11f21e9..f7bd61b 100644
> --- a/src/gallium/state_trackers/clover/api/device.cpp
> +++ b/src/gallium/state_trackers/clover/api/device.cpp
> @@ -158,7 +158,7 @@ clGetDeviceInfo(cl_device_id d_dev, cl_device_info param,
>        break;
>  
>     case CL_DEVICE_ADDRESS_BITS:
> -      buf.as_scalar<cl_uint>() = 32;
> +      buf.as_scalar<cl_uint>() = dev.address_bits();
>        break;
>  
>     case CL_DEVICE_MAX_READ_IMAGE_ARGS:
> diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp
> index 39f39f4..8825f99 100644
> --- a/src/gallium/state_trackers/clover/core/device.cpp
> +++ b/src/gallium/state_trackers/clover/core/device.cpp
> @@ -193,6 +193,12 @@ device::subgroup_size() const {
>                                        PIPE_COMPUTE_CAP_SUBGROUP_SIZE)[0];
>  }
>  
> +cl_uint
> +device::address_bits() const {
> +   return get_compute_param<uint32_t>(pipe, ir_format(),
> +                                      PIPE_COMPUTE_CAP_ADDRESS_BITS)[0];
> +}
> +
>  std::string
>  device::device_name() const {
>     return pipe->get_name(pipe);
> diff --git a/src/gallium/state_trackers/clover/core/device.hpp b/src/gallium/state_trackers/clover/core/device.hpp
> index 2857847..6cf6c7f 100644
> --- a/src/gallium/state_trackers/clover/core/device.hpp
> +++ b/src/gallium/state_trackers/clover/core/device.hpp
> @@ -68,6 +68,7 @@ namespace clover {
>  
>        std::vector<size_t> max_block_size() const;
>        cl_uint subgroup_size() const;
> +      cl_uint address_bits() const;
>        std::string device_name() const;
>        std::string vendor_name() const;
>        enum pipe_shader_ir ir_format() const;
> -- 
> 2.7.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160828/da206fbb/attachment.sig>


More information about the mesa-dev mailing list