[Mesa-dev] [PATCH] aubinator: fix if indentation and add brackets to multiline body

Kenneth Graunke kenneth at whitecape.org
Tue Aug 30 00:10:20 UTC 2016


On Tuesday, August 30, 2016 9:53:35 AM PDT Timothy Arceri wrote:
> Fixes misleading indentation warning in gcc.
> 
> Cc: Kristian Høgsberg Kristensen <krh at bitplanet.net>
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/intel/tools/disasm.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c
> index a1cb191..fcb61c4 100644
> --- a/src/intel/tools/disasm.c
> +++ b/src/intel/tools/disasm.c
> @@ -75,12 +75,13 @@ gen_disasm_disassemble(struct gen_disasm *disasm, void *assembly, int start,
>  
>        /* Simplistic, but efficient way to terminate disasm */
>        if (brw_inst_opcode(devinfo, insn) == BRW_OPCODE_SEND ||
> -          brw_inst_opcode(devinfo, insn) == BRW_OPCODE_SENDC)
> +          brw_inst_opcode(devinfo, insn) == BRW_OPCODE_SENDC) {
>           if (brw_inst_eot(devinfo, insn))
>              break;
> -         if (brw_inst_opcode(devinfo, insn) == 0)
> -            break;
> +      }
>  
> +      if (brw_inst_opcode(devinfo, insn) == 0)
> +         break;
>     }
>  }
>  
> 

I think Sirisha is going to make broader changes here shortly, but in
the meantime, please go ahead:

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160829/7f475ad5/attachment.sig>


More information about the mesa-dev mailing list