[Mesa-dev] [PATCH 09/28] XXX:configure: set HAVE_PLATFORM_foo as applicable

[Eric Engestrom]

On Thursday, 2016-12-08 19:21:49 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Should we keep this here and feed the defines to all sources or apply
> them locally ?
> 
> If we go with this approach, need to drop the other existing defines.

What "other existing defines"? I can't find anything that would use
these either.

Maybe related: I haven't received anything past patch 11/28, and it
seems neither has mailman's archive [1].
Is this something you use later in your series?

The patches so far look good to me; everything up to #8 is:
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
(with the change in #6 that you suggested)

On a related note, this series will break something I'm working on, but
isn't anywhere near ready yet anyway (-ENOTIME…) ^^

Cheers,
  Eric

[1] https://lists.freedesktop.org/archives/mesa-dev/2016-December/thread.html#137849

> ---
>  configure.ac | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 602b2c7..6bb81a2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2225,24 +2225,29 @@ for plat in $platforms; do
>  		if test "x$WAYLAND_SCANNER" = x; then
>  			AC_MSG_ERROR([wayland-scanner is needed to compile the wayland platform])
>  		fi
> +		DEFINES="$DEFINES -DHAVE_PLATFORM_WAYLAND"
>  		;;
>  
>  	x11)
>  		# XXX: split and correctly honour DRI2 vs DRI3
>  		PKG_CHECK_MODULES([XCB_DRI2], [x11-xcb xcb xcb-dri2 >= $XCBDRI2_REQUIRED xcb-xfixes])
> +		DEFINES="$DEFINES -DHAVE_PLATFORM_X11"
>  		;;
>  
>  	drm)
>  		# May not be required for the VL targets.
>  		test "x$enable_gbm" = "xno" &&
>  			AC_MSG_ERROR([EGL platform drm needs gbm])
> +		DEFINES="$DEFINES -DHAVE_PLATFORM_DRM"
>  		;;
>  
>  	surfaceless)
> +		DEFINES="$DEFINES -DHAVE_PLATFORM_SURFACELESS"
>  		;;
>  
>  	android)
>  		PKG_CHECK_MODULES([ANDROID], [cutils hardware sync])
> +		DEFINES="$DEFINES -DHAVE_PLATFORM_ANDROID"
>  		;;
>  
>  	*)
> -- 
> 2.10.2
>