[Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

Kenneth Graunke kenneth at whitecape.org
Thu Dec 22 19:50:10 UTC 2016


On Thursday, December 22, 2016 10:47:46 AM PST Haixia Shi wrote:
> Hello Mesa-Dev:
> 
> To give you some background, we are observing that mask values getting
> converted to -1 when running multiple dEQP-GLES31 tests in sequence.
> 
> There's already a previous commit
> (b8b1d83c71fd148d2fd84afdc20c0aa367114f92) that attempted to address the
> test failures by initializing all stencil values to 0xFF.
> 
> However, the test still fails when running all
> dEQP-GLES3.functional.state_query.integers#stencil_*_getfloat tests
> sequentially.
> 
> Apparently the test sets mask values to 0xffffffffU using glStencilFunc()
> API, and this overwrites the 0xFF initial value. Therefore I would propose
> that we sanitize all input stencil mask values.
> 
> Thanks,
> Haixia

Hi Haixia,

I believe I already fixed these a couple days ago in commit
37d63b50b196afe61b4d7c33b1118a49a5e1e13f.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161222/b828859a/attachment.sig>


More information about the mesa-dev mailing list