[Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

Haixia Shi hshi at chromium.org
Thu Dec 22 21:16:50 UTC 2016


Kenneth

Thank you for the commit info. Please consider this patch abandoned.

On Thu, Dec 22, 2016 at 11:50 AM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> On Thursday, December 22, 2016 10:47:46 AM PST Haixia Shi wrote:
> > Hello Mesa-Dev:
> >
> > To give you some background, we are observing that mask values getting
> > converted to -1 when running multiple dEQP-GLES31 tests in sequence.
> >
> > There's already a previous commit
> > (b8b1d83c71fd148d2fd84afdc20c0aa367114f92) that attempted to address the
> > test failures by initializing all stencil values to 0xFF.
> >
> > However, the test still fails when running all
> > dEQP-GLES3.functional.state_query.integers#stencil_*_getfloat tests
> > sequentially.
> >
> > Apparently the test sets mask values to 0xffffffffU using glStencilFunc()
> > API, and this overwrites the 0xFF initial value. Therefore I would
> propose
> > that we sanitize all input stencil mask values.
> >
> > Thanks,
> > Haixia
>
> Hi Haixia,
>
> I believe I already fixed these a couple days ago in commit
> 37d63b50b196afe61b4d7c33b1118a49a5e1e13f.
>
> --Ken
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161222/3253a202/attachment-0001.html>


More information about the mesa-dev mailing list