[Mesa-dev] [PATCH] radv: fix rendering to b10g11r11_ufloat_pack32

Edward O'Callaghan funfunctor at folklore1984.net
Fri Dec 23 07:21:06 UTC 2016


Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 12/23/2016 05:43 PM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> doom was causing a printf about an illegal color, it was due the
> non-void returning -1, and the other function checking for 4,
> align these.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_formats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
> index fe786b3..e276432 100644
> --- a/src/amd/vulkan/radv_formats.c
> +++ b/src/amd/vulkan/radv_formats.c
> @@ -394,7 +394,7 @@ uint32_t radv_translate_color_numformat(VkFormat format,
>  					int first_non_void)
>  {
>  	unsigned ntype;
> -	if (first_non_void == 4 || desc->channel[first_non_void].type == VK_FORMAT_TYPE_FLOAT)
> +	if (first_non_void == -1 || desc->channel[first_non_void].type == VK_FORMAT_TYPE_FLOAT)
>  		ntype = V_028C70_NUMBER_FLOAT;
>  	else {
>  		ntype = V_028C70_NUMBER_UNORM;
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161223/498adaea/attachment.sig>


More information about the mesa-dev mailing list