[Mesa-dev] [PATCH] radv: fix rendering to b10g11r11_ufloat_pack32

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Fri Dec 23 09:52:35 UTC 2016


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Dec 23, 2016 at 7:43 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> doom was causing a printf about an illegal color, it was due the
> non-void returning -1, and the other function checking for 4,
> align these.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_formats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
> index fe786b3..e276432 100644
> --- a/src/amd/vulkan/radv_formats.c
> +++ b/src/amd/vulkan/radv_formats.c
> @@ -394,7 +394,7 @@ uint32_t radv_translate_color_numformat(VkFormat format,
>                                         int first_non_void)
>  {
>         unsigned ntype;
> -       if (first_non_void == 4 || desc->channel[first_non_void].type == VK_FORMAT_TYPE_FLOAT)
> +       if (first_non_void == -1 || desc->channel[first_non_void].type == VK_FORMAT_TYPE_FLOAT)
>                 ntype = V_028C70_NUMBER_FLOAT;
>         else {
>                 ntype = V_028C70_NUMBER_UNORM;
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list