[Mesa-dev] [PATCH] anv, radv: disable StorageImageWriteWithoutFormat for now

[Jason Ekstrand]

ack

On Thu, Dec 29, 2016 at 10:01 PM, Dave Airlie <airlied at gmail.com> wrote:

> On 30 December 2016 at 15:52, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> > The SPIR-V capability isn't even marked as enabled, and there are no
> > tests in Vulkan-CTS. Per Jason Ekstrand, this won't work in anv as such
> > write-only surfaces require additional setup which is currently not
> > performed.
> >
> > Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> Acked-by: Dave Airlie <airlied at redhat.com>
>
> just remind me when tests show up :-)
>
> > ---
> >
> > I don't care whether this patch or the one to enable the SPIR-V cap goes
> in.
> > However the current state is inconsistent. We can even make use of the
> new
> > SPIR-V extensions capability if radv wants it on while anv wants it off.
> >
> >  src/amd/vulkan/radv_device.c  | 2 +-
> >  src/intel/vulkan/anv_device.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> > index dcbb015..e57a419 100644
> > --- a/src/amd/vulkan/radv_device.c
> > +++ b/src/amd/vulkan/radv_device.c
> > @@ -403,7 +403,7 @@ void radv_GetPhysicalDeviceFeatures(
> >                 .shaderStorageBufferArrayDynamicIndexing  = true,
> >                 .shaderStorageImageArrayDynamicIndexing   = true,
> >                 .shaderStorageImageReadWithoutFormat      = false,
> > -               .shaderStorageImageWriteWithoutFormat     = true,
> > +               .shaderStorageImageWriteWithoutFormat     = false,
> >                 .shaderClipDistance                       = true,
> >                 .shaderCullDistance                       = true,
> >                 .shaderFloat64                            = false,
> > diff --git a/src/intel/vulkan/anv_device.c
> b/src/intel/vulkan/anv_device.c
> > index ec1e0e8..69e1dc2 100644
> > --- a/src/intel/vulkan/anv_device.c
> > +++ b/src/intel/vulkan/anv_device.c
> > @@ -472,7 +472,7 @@ void anv_GetPhysicalDeviceFeatures(
> >        .shaderStorageImageExtendedFormats        = true,
> >        .shaderStorageImageMultisample            = false,
> >        .shaderStorageImageReadWithoutFormat      = false,
> > -      .shaderStorageImageWriteWithoutFormat     = true,
> > +      .shaderStorageImageWriteWithoutFormat     = false,
> >        .shaderUniformBufferArrayDynamicIndexing  = true,
> >        .shaderSampledImageArrayDynamicIndexing   = true,
> >        .shaderStorageBufferArrayDynamicIndexing  = true,
> > --
> > 2.10.2
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161230/bdf27d74/attachment.html>