[Mesa-dev] [PATCH 5/5] st/mesa/glsl: change xfb_program field to last_vert_prog

[Eric Anholt]

Timothy Arceri <timothy.arceri at collabora.com> writes:

> By making it more generic and we can short circuit a bunch of code
> paths.
>
> The new field will also be used in coming changes for more clean-ups.
>
> This change also fixes a regression caused by 700bc94dcebf425
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99231

Not sure how I feel about this one.  I like not having the xfb_program
point to the FS.  I think the rename to "last_vert_prog" is a bit
confusing (I guess it's true that it's the last stage that processes
vertices, but that name also kind of reads like "most recent vertex
program" to me).  And it sounds like the regression has been fixed
another way, so I'm not sure if you want to pursue this patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161230/23d1d593/attachment.sig>