[Mesa-dev] [PATCH 5/5] st/mesa/glsl: change xfb_program field to last_vert_prog

[Timothy Arceri]

On Fri, 2016-12-30 at 16:48 -0800, Eric Anholt wrote:
> Timothy Arceri <timothy.arceri at collabora.com> writes:
> 
> > By making it more generic and we can short circuit a bunch of code
> > paths.
> > 
> > The new field will also be used in coming changes for more clean-
> > ups.
> > 
> > This change also fixes a regression caused by 700bc94dcebf425
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99231
> 
> Not sure how I feel about this one.  I like not having the
> xfb_program
> point to the FS.  I think the rename to "last_vert_prog" is a bit
> confusing (I guess it's true that it's the last stage that processes
> vertices, but that name also kind of reads like "most recent vertex
> program" to me). 

Yeah I thought about that but last_vert_stage sounded like it just told
us which stage was the last rather than holding a pointer to
gl_program. Happy for better suggestions.

>  And it sounds like the regression has been fixed
> another way, so I'm not sure if you want to pursue this patch.

I still like this patch because it allows this clean-up [1]. 

Anyway thanks for reviewing the other 4 I think I'll commit those
sometime over the next few days and do a resend of the remaining
patches from the 70 patch series.


[1] https://patchwork.freedesktop.org/patch/128780/

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev