[Mesa-dev] [PATCH] compiler: removed unused Makefile.sources

Matt Turner mattst88 at gmail.com
Mon Feb 1 18:11:08 UTC 2016


On Sun, Jan 31, 2016 at 2:27 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 30 January 2016 at 23:03, Rob Clark <robdclark at gmail.com> wrote:
>> On Sat, Jan 30, 2016 at 3:38 PM, Rob Herring <robh at kernel.org> wrote:
>>> On Sat, Jan 30, 2016 at 2:06 PM, Rob Clark <robdclark at gmail.com> wrote:
>>>> From: Rob Clark <robclark at freedesktop.org>
>>>>
>>>> We seem to end up w/ duplication between compiler/Makefile.sources and
>>>> compiler/glsl/Makefile.sources.  The latter appears unused.  Delete it.
>>>
>>> The fixes for Android I sent yesterday use it. But at least the nir/*
>>> files could be removed.
>>
>> oh.. hmm.. is it possible for android to use the same
>> compiler/Makefile.sources?  Or is this just a temporary situation?
>>
> It's aimed as temporary solution. I'm planning to rework that real soon (tm).
>
>> I'm adding new src files and bit confusing at the moment to know which
>> places to update..
>>
> Sorry about that. Please update both places, alternatively we'll fix
> thing it when needed.

Why are things like they are now? What is using nir/Makefile.sources
or glsl/Makefile.sources? glsl/Makefile.am looks plainly dead.

Leaving these file in place is *mean*. Rebasing patches that touch
them onto these changes will update the wrong files.


More information about the mesa-dev mailing list